Skip to content

More integration tests #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 29, 2020
Merged

More integration tests #173

merged 8 commits into from
Dec 29, 2020

Conversation

kiran-chaudhary
Copy link
Contributor

Added trivial integration test cases, those that do not need any pre-test setup or cleanup.

@github-actions
Copy link

github-actions bot commented Dec 9, 2020 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️

kiran-chaudhary
kiran-chaudhary commented Dec 9, 2020
View reviewed changes
integration/test_departing_employee.py
(f"{DEPARTING_EMPLOYEE_COMMAND} bulk remove", "Missing argument 'FILE'."),
],
)
def test_departing_employee_command_returns_error_exit_status_when_missing_required_parameters(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These negative tests should fall under unit tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree. Should we move them to their respective unit test modules? There might some tests of this similar nature dispersed already, but I know there is not a ton

antazoey
antazoey reviewed Dec 9, 2020
View reviewed changes
integration/test_alert_rules.py Outdated
@pytest.mark.parametrize(
"command",
[
f"{ALERT_RULES_COMMAND} list",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string.format is more consistent with how we format strings in py42

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

@antazoey
Copy link
Contributor

These look good! I have the same thought as you - that the negatives tests are more like integration tests when they verify args are present. I think they are good tests to have. Just recently, we had a big where deleting profile name arg was no required, these tests would have caught that earlier.

antazoey
antazoey approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for now, but some of the same improvements for py42 integration tests apply here (make able to run via pytest)

@kiran-chaudhary
Copy link
Contributor Author

looks good for now, but some of the same improvements for py42 integration tests apply here (make able to run via pytest)

Changed.

timabrmsn
timabrmsn approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@timabrmsn timabrmsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Were you still going to remove/move those negative tests that should be covered by unit tests?

@kiran-chaudhary
Copy link
Contributor Author

LGTM. Were you still going to remove/move those negative tests that should be covered by unit tests?

We will keep those tests and I have added the integration marker to all positive cases here. So they both will stay. Now I plan to move all of them to tests directory after merging them.

@kiran-chaudhary kiran-chaudhary merged commit 1be5908 into master Dec 29, 2020
@kiran-chaudhary kiran-chaudhary deleted the more-integration-tests branch December 29, 2020 04:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timabrmsn timabrmsn timabrmsn approved these changes

@antazoey antazoey antazoey approved these changes

@alanag13 alanag13 Awaiting requested review from alanag13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiran-chaudhary @antazoey @timabrmsn